Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: base/metrics/bucket_ranges.h

Issue 2949983002: Inline BucketRanges::set_range (Closed)
Patch Set: switch to dcheck Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/bucket_ranges.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/bucket_ranges.h
diff --git a/base/metrics/bucket_ranges.h b/base/metrics/bucket_ranges.h
index db82e552b3ac5c193ffbed00e7c195008dd15681..578119f26bca839f8e6cded121920a87c1995c25 100644
--- a/base/metrics/bucket_ranges.h
+++ b/base/metrics/bucket_ranges.h
@@ -40,7 +40,11 @@ class BASE_EXPORT BucketRanges {
size_t size() const { return ranges_.size(); }
HistogramBase::Sample range(size_t i) const { return ranges_[i]; }
- void set_range(size_t i, HistogramBase::Sample value);
+ void set_range(size_t i, HistogramBase::Sample value) {
+ DCHECK_LT(i, ranges_.size());
+ DCHECK_GE(value, 0);
+ ranges_[i] = value;
+ }
uint32_t checksum() const { return checksum_; }
void set_checksum(uint32_t checksum) { checksum_ = checksum; }
« no previous file with comments | « no previous file | base/metrics/bucket_ranges.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698