Inline BucketRanges::set_range

base/metrics/bucket_ranges.h

Index: base/metrics/bucket_ranges.h
diff --git a/base/metrics/bucket_ranges.h b/base/metrics/bucket_ranges.h
index db82e552b3ac5c193ffbed00e7c195008dd15681..23cfc053c0b644a54175486f64091f1cd98621f7 100644
--- a/base/metrics/bucket_ranges.h
+++ b/base/metrics/bucket_ranges.h
@@ -40,7 +40,11 @@ class BASE_EXPORT BucketRanges {
 
   size_t size() const { return ranges_.size(); }
   HistogramBase::Sample range(size_t i) const { return ranges_[i]; }
-  void set_range(size_t i, HistogramBase::Sample value);
+  void set_range(size_t i, HistogramBase::Sample value) {
+    DCHECK_LT(i, ranges_.size());
+    CHECK_GE(value, 0);
+    ranges_[i] = value;

[Nico, 2017/06/21 01:03:37]

Kind of weird that one is a dcheck but the other a check

[hans, 2017/06/21 01:11:46]

Good point. It was added in https://chromiumcodereview.appspot.com/10857025 five
years ago "Add more code for debugging. We will revert this change when we find
out the reason of corruption."

Let's change it to a DCHECK..

+  }
   uint32_t checksum() const { return checksum_; }
   void set_checksum(uint32_t checksum) { checksum_ = checksum; }