Inline BucketRanges::set_range

base/metrics/bucket_ranges.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // BucketRanges stores the vector of ranges that delimit what samples are
 // tallied in the corresponding buckets of a histogram. Histograms that have
 // same ranges for all their corresponding buckets should share the same
 // BucketRanges object.
 //
 // E.g. A 5 buckets LinearHistogram with 1 as minimal value and 4 as maximal
@@ skipping 22 matching lines @@
 
 class BASE_EXPORT BucketRanges {
  public:
   typedef std::vector<HistogramBase::Sample> Ranges;
 
   explicit BucketRanges(size_t num_ranges);
   ~BucketRanges();
 
   size_t size() const { return ranges_.size(); }
   HistogramBase::Sample range(size_t i) const { return ranges_[i]; }
-  void set_range(size_t i, HistogramBase::Sample value);
+  void set_range(size_t i, HistogramBase::Sample value) {
+    DCHECK_LT(i, ranges_.size());
+    CHECK_GE(value, 0);
+    ranges_[i] = value;

[Nico, 2017/06/21 01:03:37]

Kind of weird that one is a dcheck but the other a check

[hans, 2017/06/21 01:11:46]

Good point. It was added in https://chromiumcodereview.appspot.com/10857025 five
years ago "Add more code for debugging. We will revert this change when we find
out the reason of corruption."

Let's change it to a DCHECK..

+  }
   uint32_t checksum() const { return checksum_; }
   void set_checksum(uint32_t checksum) { checksum_ = checksum; }
 
   // A bucket is defined by a consecutive pair of entries in |ranges|, so there
   // is one fewer bucket than there are ranges.  For example, if |ranges| is
   // [0, 1, 3, 7, INT_MAX], then the buckets in this histogram are
   // [0, 1), [1, 3), [3, 7), and [7, INT_MAX).
   size_t bucket_count() const { return ranges_.size() - 1; }
 
   // Checksum methods to verify whether the ranges are corrupted (e.g. bad
@@ skipping 38 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(BucketRanges);
 };
 
 //////////////////////////////////////////////////////////////////////////////
 // Expose only for test.
 BASE_EXPORT extern const uint32_t kCrcTable[256];
 
 }  // namespace base
 
 #endif  // BASE_METRICS_BUCKET_RANGES_H_