Issue 2949943002: Revert "Updated parser to produce error when trying to reinitialize final variables in class constr…

Issue 2949943002: Revert "Updated parser to produce error when trying to reinitialize final variables in class constr… (Closed)

Created:
3 years, 6 months ago by Alan Knight

Modified:
3 years, 6 months ago

Reviewers:
bkonyi

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658." This reverts commit 9755a98b003a09a0f3aa76b610bcf715e58b0baa. BUG= Committed: https://github.com/dart-lang/sdk/commit/12e93cc41eed955245cae7bf8a8e931f23cc6fb6

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -89 lines)			Patch
M	runtime/vm/parser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	3 chunks	+0 lines, -49 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/language/const_error_multiply_initialized_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	tests/language/final_attempt_reinitialization_test.dart	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Alan Knight

Committed patchset #1 (id:1) manually as 12e93cc41eed955245cae7bf8a8e931f23cc6fb6 (presubmit successful).

3 years, 6 months ago (2017-06-20 22:26:15 UTC) #4

Message was sent while issue was closed.

LGTM