Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2949893002: Add support for running pub for plugins (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 4 chunks +19 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 4 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Unfortunately, we can't test this yet. I'm happy to hold off on committing it until ...
3 years, 6 months ago (2017-06-20 19:22:35 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 15:40:30 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-06-26 16:21:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66986042afac3e5528290a714350a7fc1f725c9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698