Issue 2949823003: Simplify enqueueBrowserTest().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2949823003: Simplify enqueueBrowserTest(). (Closed)

Created:
3 years, 6 months ago by Bob Nystrom

Modified:
3 years, 6 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Simplify enqueueBrowserTest(). It's still big and monolithic, but it's not as big as it was before. - Remove old unused Polymer stuff. - Move some of the logic out into a helper function. - Other small tweaks. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/dfb4f52b43fda5eab6beb330c9e0e8f9958b6992

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -150 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View	1	14 chunks	+99 lines, -146 lines	0 comments	Download
	M	tools/testing/dart/utils.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 6 months ago (2017-06-23 22:02:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
dfb4f52b43fda5eab6beb330c9e0e8f9958b6992 (presubmit successful).