Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2949823002: Remove unused implementation of SearchEngine and rename the driver-based implementation (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused implementation of SearchEngine and rename the driver-based implementation R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/53e01faa43b2e2029e2f818b8eefa826897a03ff

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-20 16:44:54 UTC) #2
Brian Wilkerson
3 years, 6 months ago (2017-06-21 15:58:56 UTC) #4
devoncarew
lgtm
3 years, 6 months ago (2017-06-21 16:26:48 UTC) #5
Brian Wilkerson
Committed patchset #1 (id:1) manually as 53e01faa43b2e2029e2f818b8eefa826897a03ff (presubmit successful).
3 years, 6 months ago (2017-06-21 16:33:57 UTC) #7
scheglov
3 years, 5 months ago (2017-06-26 15:31:08 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698