runtime/vm/raw_object.cc - Issue 2949803002: New growth strategy for growable arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object.cc

Issue 2949803002: New growth strategy for growable arrays (Closed)

Patch Set: Branch-free grow size computation. Renamed function names to be clearer. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/raw_object.cc

diff --git a/runtime/vm/raw_object.cc b/runtime/vm/raw_object.cc

index edbe107a46d23d83c71b9ace3b0924e431970e1d..15dfe26aecdd23e323c5756cbd7ee26b70dfb869 100644

--- a/runtime/vm/raw_object.cc

+++ b/runtime/vm/raw_object.cc

@@ -199,7 +199,7 @@ intptr_t RawObject::SizeFromClass() const {

uword tags = ptr()->tags_;

intptr_t tags_size = SizeTag::decode(tags);

if ((class_id == kArrayCid) && (instance_size > tags_size && tags_size > 0)) {

- // TODO(22501): Array::MakeArray could be in the process of shrinking

+ // TODO(22501): Array::MakeFixedLength could be in the process of shrinking

// the array (see comment therein), having already updated the tags but not

// yet set the new length. Wait a millisecond and try again.

int retries_remaining = 1000; // ... but not forever.

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »