New growth strategy for growable arrays

runtime/vm/profiler_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
 #include "vm/globals.h"
 #include "vm/profiler.h"
@@ skipping 1009 matching lines @@
   // Run bar.
   result = Dart_Invoke(lib, NewString("bar"), 0, NULL);
   EXPECT_VALID(result);
 
   {
     StackZone zone(thread);
     HANDLESCOPE(thread);
     Profile profile(isolate);
     AllocationFilter filter(isolate->main_port(), array_class.id());
     profile.Build(thread, &filter, Profile::kNoTags);
-    // We should still only have one allocation sample.
-    EXPECT_EQ(1, profile.sample_count());
-    ProfileTrieWalker walker(&profile);
-
-    walker.Reset(Profile::kExclusiveCode);
-    EXPECT(walker.Down());
-    EXPECT_STREQ("DRT_AllocateArray", walker.CurrentName());
-    EXPECT(walker.Down());
-    EXPECT_STREQ("[Stub] AllocateArray", walker.CurrentName());
-    EXPECT(walker.Down());
-    EXPECT_STREQ("new _List", walker.CurrentName());
-    EXPECT(walker.Down());
-    EXPECT_STREQ("new _GrowableList", walker.CurrentName());
-    EXPECT(walker.Down());
-    EXPECT_STREQ("new List._internal", walker.CurrentName());
-    EXPECT(walker.Down());
-    EXPECT_STREQ("bar", walker.CurrentName());
-    EXPECT(!walker.Down());
+    // We should have no allocation samples, since empty
+    // growable lists use a shared backing.
+    EXPECT_EQ(0, profile.sample_count());
   }
 }
 
 
 TEST_CASE(Profiler_ContextAllocation) {
   DisableNativeProfileScope dnps;
   const char* kScript =
       "var msg1 = 'a';\n"
       "foo() {\n"
       "  var msg = msg1 + msg1;\n"
@@ skipping 1853 matching lines @@
   EXPECT_EQ(table->FindCodeForPC(45), code1);  // Merged right.
   EXPECT_EQ(table->FindCodeForPC(54), code1);  // Merged right.
   EXPECT_EQ(table->FindCodeForPC(20), code2);  // Merged left.
   EXPECT_EQ(table->FindCodeForPC(49), code1);  // Truncated.
   EXPECT_EQ(table->FindCodeForPC(50), code1);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart