Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: milo/appengine/job_source/buildbucket/builder_test.go

Issue 2949783002: [milo] appengine/* -> * (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/job_source/buildbucket/builder.go ('k') | milo/appengine/job_source/buildbucket/common.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/job_source/buildbucket/builder_test.go
diff --git a/milo/appengine/job_source/buildbucket/builder_test.go b/milo/appengine/job_source/buildbucket/builder_test.go
deleted file mode 100644
index 44859502db385b8b58e61fe9fe83c76bde2a2b7a..0000000000000000000000000000000000000000
--- a/milo/appengine/job_source/buildbucket/builder_test.go
+++ /dev/null
@@ -1,84 +0,0 @@
-// Copyright 2016 The LUCI Authors. All rights reserved.
-// Use of this source code is governed under the Apache License, Version 2.0
-// that can be found in the LICENSE file.
-
-package buildbucket
-
-import (
- "encoding/json"
- "flag"
- "fmt"
- "io/ioutil"
- "os"
- "path/filepath"
- "testing"
-
- "github.com/luci/gae/impl/memory"
- "github.com/luci/luci-go/common/clock/testclock"
- memcfg "github.com/luci/luci-go/common/config/impl/memory"
- "github.com/luci/luci-go/luci_config/server/cfgclient/backend/testconfig"
- "github.com/luci/luci-go/milo/appengine/common"
- "golang.org/x/net/context"
-
- . "github.com/smartystreets/goconvey/convey"
-)
-
-var generate = flag.Bool("test.generate", false, "Generate expectations instead of running tests.")
-
-func TestBuilder(t *testing.T) {
- t.Parallel()
-
- testCases := []struct{ bucket, builder string }{
- {"master.tryserver.infra", "InfraPresubmit"},
- {"master.tryserver.infra", "InfraPresubmit.Swarming"},
- }
-
- Convey("Builder", t, func() {
- c := memory.UseWithAppID(context.Background(), "luci-milo-dev")
- c, _ = testclock.UseTime(c, testclock.TestRecentTimeUTC)
- c = testconfig.WithCommonClient(c, memcfg.New(bktConfigFull))
- // Update the service config so that the settings are loaded.
- err := common.UpdateServiceConfig(c)
- So(err, ShouldBeNil)
-
- for _, tc := range testCases {
- tc := tc
- Convey(fmt.Sprintf("%s:%s", tc.bucket, tc.builder), func() {
- expectationFilePath := filepath.Join("expectations", tc.bucket, tc.builder+".json")
- err := os.MkdirAll(filepath.Dir(expectationFilePath), 0777)
- So(err, ShouldBeNil)
-
- actual, err := builderImpl(c,
- builderQuery{
- Bucket: tc.bucket,
- Builder: tc.builder,
- Limit: 0,
- })
- So(err, ShouldBeNil)
- actualJSON, err := json.MarshalIndent(actual, "", " ")
- So(err, ShouldBeNil)
-
- if *generate {
- err := ioutil.WriteFile(expectationFilePath, actualJSON, 0777)
- So(err, ShouldBeNil)
- } else {
- expectedJSON, err := ioutil.ReadFile(expectationFilePath)
- So(err, ShouldBeNil)
- So(string(actualJSON), ShouldEqual, string(expectedJSON))
- }
- })
- }
- })
-}
-
-var bktConfig = `
-buildbucket: {
- host: "debug"
-}
-`
-
-var bktConfigFull = map[string]memcfg.ConfigSet{
- "services/luci-milo-dev": {
- "settings.cfg": bktConfig,
- },
-}
« no previous file with comments | « milo/appengine/job_source/buildbucket/builder.go ('k') | milo/appengine/job_source/buildbucket/common.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698