Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 2949763002: Introduce Position constructor with const Node& (Closed)
Patch Set: 2017-06-20T13:43:23 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.h
diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h
index bb8a7240818a9fff957921fb67b1e2abe367efff..ee2d0e8d73ca298282a046a3db066f918e8cab54 100644
--- a/third_party/WebKit/Source/core/editing/Position.h
+++ b/third_party/WebKit/Source/core/editing/Position.h
@@ -70,8 +70,12 @@ class CORE_TEMPLATE_CLASS_EXPORT PositionTemplate {
PositionTemplate(Node* anchor_node, PositionAnchorType);
// For creating offset positions:
- // FIXME: This constructor should eventually go away. See bug 63040.
- PositionTemplate(Node* anchor_node, int offset);
+ PositionTemplate(const Node& anchor_node, int offset);
+ // TODO(editing-dev): We should not pass |nullptr| as |anchor_node| for
+ // |Position| constructor.
+ // TODO(editing-dev): This constructor should eventually go away. See bug
+ // http://wkb.ug/63040.
+ PositionTemplate(const Node* anchor_node, int offset);
PositionTemplate(const PositionTemplate&);

Powered by Google App Engine
This is Rietveld 408576698