Introduce Position constructor with const Node&

third_party/WebKit/Source/core/editing/SelectionEditor.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 259 matching lines @@
     DidFinishDOMMutation();
     return;
   }
   const Position& new_base = UpdatePositionAfterAdoptingTextReplacement(
       selection_.base_, node, offset, old_length, new_length);
   const Position& new_extent = UpdatePositionAfterAdoptingTextReplacement(
       selection_.extent_, node, offset, old_length, new_length);
   DidFinishTextChange(new_base, new_extent);
 }
 
-// TODO(yosin): We should introduce |Position(const Text&, int)| to avoid
-// |const_cast<Text*>|.
 static Position UpdatePostionAfterAdoptingTextNodesMerged(
     const Position& position,
     const Text& merged_node,
     const NodeWithIndex& node_to_be_removed_with_index,
     unsigned old_length) {
   Node* const anchor_node = position.AnchorNode();
   const Node& node_to_be_removed = node_to_be_removed_with_index.GetNode();
   switch (position.AnchorType()) {
     case PositionAnchorType::kBeforeChildren:
     case PositionAnchorType::kAfterChildren:
       return position;
     case PositionAnchorType::kBeforeAnchor:
       if (anchor_node == node_to_be_removed)
-        return Position(const_cast<Text*>(&merged_node), merged_node.length());
+        return Position(merged_node, merged_node.length());
       return position;
     case PositionAnchorType::kAfterAnchor:
       if (anchor_node == node_to_be_removed)
-        return Position(const_cast<Text*>(&merged_node), merged_node.length());
+        return Position(merged_node, merged_node.length());
       if (anchor_node == merged_node)
-        return Position(const_cast<Text*>(&merged_node), old_length);
+        return Position(merged_node, old_length);
       return position;
     case PositionAnchorType::kOffsetInAnchor: {
       const int offset = position.OffsetInContainerNode();
       if (anchor_node == node_to_be_removed)
-        return Position(const_cast<Text*>(&merged_node), old_length + offset);
+        return Position(merged_node, old_length + offset);
       if (anchor_node == node_to_be_removed.parentNode() &&
           offset == node_to_be_removed_with_index.Index()) {
-        return Position(const_cast<Text*>(&merged_node), old_length);
+        return Position(merged_node, old_length);
       }
       return position;
     }
   }
   NOTREACHED() << position;
   return position;
 }
 
 void SelectionEditor::DidMergeTextNodes(
     const Text& merged_node,
@@ skipping 124 matching lines @@
 DEFINE_TRACE(SelectionEditor) {
   visitor->Trace(frame_);
   visitor->Trace(selection_);
   visitor->Trace(cached_visible_selection_in_dom_tree_);
   visitor->Trace(cached_visible_selection_in_flat_tree_);
   visitor->Trace(cached_range_);
   SynchronousMutationObserver::Trace(visitor);
 }
 
 }  // namespace blink