Print static types of conditional expressions.

Print static types of conditional expressions.

I want to start testing that Fasta sets the static types of
conditional expressions correctly, so I need Fasta's expectations
files to include them.

This CL just adds the static types to the printing logic in
ast_to_text.dart and updates expectations so that the tests continue
to pass.  I will make behavioral changes to Fasta in future CLs.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/1594006758c40688c466b4e93ea49c31ab53a78d

[Paul Berry, 2017-06-20 02:51:50]

paulberry@google.com changed reviewers:
+ ahe@google.com

[Paul Berry, 2017-06-20 02:52:17]

Note: the only substantial change is in pkg/kernel/lib/text/ast_to_text.dart. 
Everything else is just modifications to expectations files.

[Paul Berry, 2017-06-20 12:10:59]

paulberry@google.com changed reviewers:
+ kmillikin@google.com

[Paul Berry, 2017-06-20 12:11:00]

Kevin, can you take a look since Peter is on vacation?

[Kevin Millikin (Google), 2017-06-20 13:14:11]

I would prefer a notation that generalized in an obvious way to other
expressions, because I'm expecting that we could eventually want them.

Unfortunately, we already have : in the syntax of ?: and we have used :: for
qualified names, and {} is already overloaded.

We can stick with this for now.  I suspect generalizing will require a bigger
overhaul of the syntax.

LGTM.

[Paul Berry, 2017-06-20 14:28:58]

On 2017/06/20 13:14:11, Kevin Millikin (Google) wrote:
> I would prefer a notation that generalized in an obvious way to other
> expressions, because I'm expecting that we could eventually want them.
> 
> Unfortunately, we already have : in the syntax of ?: and we have used :: for
> qualified names, and {} is already overloaded.
> 
> We can stick with this for now.  I suspect generalizing will require a bigger
> overhaul of the syntax.
> 
> LGTM.

Acknowledged.  I'm happy to help with the change when the time is right.

Thanks for the review!

[Paul Berry, 2017-06-20 14:33:59]

Description was changed from

==========
Print static types of conditional expressions.

I want to start testing that Fasta sets the static types of
conditional expressions correctly, so I need Fasta's expectations
files to include them.

This CL just adds the static types to the printing logic in
ast_to_text.dart and updates expectations so that the tests continue
to pass.  I will make behavioral changes to Fasta in future CLs.
==========

to

==========
Print static types of conditional expressions.

I want to start testing that Fasta sets the static types of
conditional expressions correctly, so I need Fasta's expectations
files to include them.

This CL just adds the static types to the printing logic in
ast_to_text.dart and updates expectations so that the tests continue
to pass.  I will make behavioral changes to Fasta in future CLs.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1594006758c40688c466b4e93ea49c31ab53a78d
==========

[Paul Berry, 2017-06-20 14:34:01]

Committed patchset #1 (id:1) manually as
1594006758c40688c466b4e93ea49c31ab53a78d (presubmit successful).