Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 294973011: Turns on S_COMMIT_OR_SKP for more perf bots. (Closed)

Created:
6 years, 7 months ago by benchen
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Turns on S_COMMIT_OR_SKP for more perf bots. BUG=skia:2576 NOTRY=true Committed: https://skia.googlesource.com/buildbot/+/f454d042e0f91a1999f6e9f53bbe59179255e4d3

Patch Set 1 #

Patch Set 2 : fix wrong win8 hd7770 bot. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M master/master_android_builders_cfg.py View 1 chunk +1 line, -1 line 0 comments Download
M master/master_builders_cfg.py View 1 3 chunks +4 lines, -4 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
benchen
This will follow the trigger addition CL https://codereview.chromium.org/291343008/ https://codereview.chromium.org/294973011/diff/20001/master/master_builders_cfg.py File master/master_builders_cfg.py (right): https://codereview.chromium.org/294973011/diff/20001/master/master_builders_cfg.py#newcode331 master/master_builders_cfg.py:331: ('Perf', ...
6 years, 7 months ago (2014-05-23 13:51:19 UTC) #1
borenet
Code change LGTM. Adding Rob and Brian to ask if we can be even more ...
6 years, 7 months ago (2014-05-23 14:13:44 UTC) #2
bsalomon
Rob and I asked Ben to turn on triggers for these bots. https://codereview.chromium.org/294973011/diff/20001/master/master_builders_cfg.py File master/master_builders_cfg.py ...
6 years, 7 months ago (2014-05-23 14:24:50 UTC) #3
benchen
The CQ bit was checked by bensong@google.com
6 years, 7 months ago (2014-05-23 16:00:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/294973011/20001
6 years, 7 months ago (2014-05-23 16:01:26 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 16:01:33 UTC) #6
Message was sent while issue was closed.
Change committed as f454d042e0f91a1999f6e9f53bbe59179255e4d3

Powered by Google App Engine
This is Rietveld 408576698