Tools/Scripts/webkitpy/layout_tests/port/driver.py - Issue 294973008: Add --sanitizer-mode to run-webkit-tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/driver.py

Issue 294973008: Add --sanitizer-mode to run-webkit-tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rename command line flag, add tests; ready for review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/port/driver.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/driver.py b/Tools/Scripts/webkitpy/layout_tests/port/driver.py

index 25ccca0b7766b5e612f21c7b122b91adc0b6f0fd..a3364d01947276ed92edb06aae6bc9a121dd7645 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/driver.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/driver.py

@@ -167,6 +167,10 @@ class Driver(object):

pid = self._server_process.pid()

leaked = self._leaked

+ if not crashed and 'AddressSanitizer' in self.error_from_test:

+ self.error_from_test = 'OUTPUT CONTAINS "AddressSanitizer", so we are treating this test as if it crashed, even though it did not.\n\n' + self.error_from_test

+ crashed = True

if stop_when_done or crashed or timed_out or leaked:

# We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output.

# In the timeout case, we kill the hung process as well.