Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 294963005: [GCM] Build mcs_probe with gcm_unit_tests (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
Reviewers:
fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Build mcs_probe with gcm_unit_tests This allows trybots to verify that mcs_probe compiles, without actually attempting to run it. BUG=364257 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M google_apis/gcm/gcm.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
PTAL
6 years, 7 months ago (2014-05-20 23:58:35 UTC) #1
fgorski
lgtm Actually quite neat solution to the problem. Please make sure the description clearly explains ...
6 years, 7 months ago (2014-05-21 03:04:13 UTC) #2
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 7 months ago (2014-05-21 19:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/294963005/1
6 years, 7 months ago (2014-05-21 19:58:14 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:11:52 UTC) #5
Message was sent while issue was closed.
Change committed as 272066

Powered by Google App Engine
This is Rietveld 408576698