Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294963004: Revert of Add OnDisplayMetricsChanged in DisplayObserver. (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, tdanderson+overview_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, danakj+watch_chromium.org, James Su, ben+ash_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_orientation
Visibility:
Public.

Description

Revert of Add OnDisplayMetricsChanged in DisplayObserver. (https://codereview.chromium.org/259253002/) Reason for revert: Breaks DesktopScreenX11Test.RemoveMonitorOnRight and AddMonitorToTheRight on Linux Tests TBR=mlamouri@chromium.org NOTRY=true NOTREECHECKS=true http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=11092 Original issue's description: > Add OnDisplayMetricsChanged in DisplayObserver. > > This replaces OnDisplayBoundsChanged and add a MetricsType > parameter so consumers can now which metrics has changed. The > current set of MetricsType include bounds, workarea and rotation. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -390 lines) Patch
M ash/display/display_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/display/display_controller.cc View 3 chunks +11 lines, -17 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 22 chunks +2 lines, -40 lines 0 comments Download
M ash/display/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager.cc View 8 chunks +25 lines, -46 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 4 chunks +6 lines, -15 lines 0 comments Download
M ash/display/resolution_notification_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/display/resolution_notification_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/screen_ash.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/display/screen_ash.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M ash/shelf/shelf_window_watcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/shell/window_watcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/window_watcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/touch/touch_hud_debug.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/wm/overview/window_selector.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/system_info/system_info_api.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_overscan_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M media/video/capture/linux/video_capture_device_chromeos.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ui/gfx/display_observer.h View 2 chunks +2 lines, -14 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +9 lines, -25 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 4 chunks +16 lines, -110 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nicolas Zea
Created Revert of Add OnDisplayMetricsChanged in DisplayObserver.
6 years, 7 months ago (2014-05-20 23:15:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/294963004/1
6 years, 7 months ago (2014-05-20 23:16:00 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 23:16:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-20 23:16:02 UTC) #4
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 7 months ago (2014-05-20 23:17:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/294963004/1
6 years, 7 months ago (2014-05-20 23:18:26 UTC) #6
Nicolas Zea
The CQ bit was unchecked by zea@chromium.org
6 years, 7 months ago (2014-05-20 23:25:09 UTC) #7
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 7 months ago (2014-05-20 23:25:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/294963004/1
6 years, 7 months ago (2014-05-20 23:25:42 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 23:28:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 271782

Powered by Google App Engine
This is Rietveld 408576698