Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 294963002: SSE2 everywhere. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SSE2 everywhere. As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and requires SSSE3 on Macs). Android already requires SSE2 for x86 chips. This effectively just forces it on for 32-bit Linux builds; everyone else already had it. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14800

Patch Set 1 #

Patch Set 2 : try again forcing sse for fp math #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
mtklein
6 years, 7 months ago (2014-05-20 14:24:22 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-20 14:41:43 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 14:42:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/294963002/1
6 years, 7 months ago (2014-05-20 14:42:28 UTC) #4
commit-bot: I haz the power
Change committed as 14800
6 years, 7 months ago (2014-05-20 14:54:10 UTC) #5
mtklein
A revert of this CL has been created in https://codereview.chromium.org/282093015/ by mtklein@google.com. The reason for ...
6 years, 7 months ago (2014-05-20 15:26:57 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 18:48:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/294963002/20001
6 years, 7 months ago (2014-05-20 18:48:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 18:53:42 UTC) #9
commit-bot: I haz the power
Failed to commit the patch. Sending gyp/common_conditions.gypi Transmitting file data .svn: Commit failed (details follow): ...
6 years, 7 months ago (2014-05-20 18:53:43 UTC) #10
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 18:55:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/294963002/20001
6 years, 7 months ago (2014-05-20 18:56:00 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 18:56:15 UTC) #13
commit-bot: I haz the power
Failed to commit the patch. Sending gyp/common_conditions.gypi Transmitting file data .svn: Commit failed (details follow): ...
6 years, 7 months ago (2014-05-20 18:56:15 UTC) #14
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 18:57:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/294963002/20001
6 years, 7 months ago (2014-05-20 18:58:03 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 18:58:16 UTC) #17
commit-bot: I haz the power
Failed to commit the patch. Sending gyp/common_conditions.gypi Transmitting file data .svn: Commit failed (details follow): ...
6 years, 7 months ago (2014-05-20 18:58:17 UTC) #18
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 19:02:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/294963002/20001
6 years, 7 months ago (2014-05-20 19:02:48 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 19:03:08 UTC) #21
commit-bot: I haz the power
Failed to commit the patch. Sending gyp/common_conditions.gypi Transmitting file data .svn: Commit failed (details follow): ...
6 years, 7 months ago (2014-05-20 19:03:09 UTC) #22
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 19:08:51 UTC) #23
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 19:09:16 UTC) #24

Powered by Google App Engine
This is Rietveld 408576698