third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp - Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

Issue 2949593003: Move navigation-induced hiding of form-validation-bubble to the browser process. (Closed)

Patch Set: Remove now unnecessary call from WebContentsImpl::RenderViewTerminated to delegate_->HideValidation… Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

index 470da5e07ea3dc35e9023b1457e26f256dc751ba..11b697b04a4fcbe41a2e0746d33b0c60bea9d032 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

@@ -41,8 +41,6 @@ class MockValidationMessageClient

return anchor_ == &anchor;

}

- void WillUnloadDocument(const Document&) override {}

- void DocumentDetached(const Document&) override {}

void WillBeDestroyed() override {}

DEFINE_INLINE_VIRTUAL_TRACE() {

visitor->Trace(anchor_);