Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 294953002: Oilpan: enable Oilpan by default in modules/quota. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: enable Oilpan by default in modules/quota. Move the quota objects, but keep the supplements as using transition types until Navigator/Window/WorkerGlobalScope are heap supplementables. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -34 lines) Patch
M Source/modules/quota/DOMWindowQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.h View 3 chunks +5 lines, -8 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/quota/StorageInfo.h View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/modules/quota/StorageInfo.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/modules/quota/StorageQuota.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look. There is no particular urgency to do this (nor reasons not ...
6 years, 7 months ago (2014-05-21 10:45:51 UTC) #1
zerny-chromium
lgtm
6 years, 7 months ago (2014-05-21 11:01:05 UTC) #2
haraken
LGTM in terms of oilpan. Let's wait for an approval from kinuko-san.
6 years, 7 months ago (2014-05-21 11:04:39 UTC) #3
kinuko
lgtm
6 years, 7 months ago (2014-05-22 04:50:02 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-22 21:24:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/294953002/1
6 years, 7 months ago (2014-05-22 21:24:44 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 00:35:54 UTC) #7
Message was sent while issue was closed.
Change committed as 174616

Powered by Google App Engine
This is Rietveld 408576698