Issue 2949513002: Revert "Reduce copying, redundancy & repetition for codegen of comparison instructions"

Issue 2949513002: Revert "Reduce copying, redundancy & repetition for codegen of comparison instructions" (Closed)

Created:
3 years, 6 months ago by erikcorry

Modified:
3 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Reduce copying, redundancy & repetition for codegen of comparison instructions" R=kustermann@google.com BUG= This reverts commit e25dfc07d193246eb30eedf085141e9f65e98b06. Reason: Failure on SIMDBC64 Committed: https://github.com/dart-lang/sdk/commit/1f7d2d543945f42b27c6aa84b15c3b3d40c535a0

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+902 lines, -315 lines)			Patch
M	runtime/vm/assembler_mips.h	View	3 chunks	+5 lines, -25 lines	0 comments	Download
M	runtime/vm/constants_arm.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/constants_dbc.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/constants_ia32.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/constants_x64.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	17 chunks	+45 lines, -66 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	11 chunks	+172 lines, -43 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	11 chunks	+155 lines, -27 lines	0 comments	Download
M	runtime/vm/intermediate_language_dbc.cc	View	10 chunks	+121 lines, -89 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	8 chunks	+127 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	11 chunks	+142 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	10 chunks	+128 lines, -17 lines	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 6 months ago (2017-06-19 08:28:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1f7d2d543945f42b27c6aa84b15c3b3d40c535a0 (presubmit successful).