Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

Issue 294943002: Try to enable root when starting adb, as root is needed for a full coverage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
index 846e47d8d667b712b6ecbd267e3c1c48f6b6d3a6..2fa9fd0ad2e6bd2d9fe08246dd26fa1fb6b73cde 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
@@ -199,6 +199,10 @@ def FindAllAvailableBrowsers(finder_options, logging=real_logging):
device = devices[0]
adb = adb_commands.AdbCommands(device=device)
+ # Trying to root the device, if possible.
+ if not adb.IsRootEnabled():
tonyg 2014/05/20 11:53:38 Is this check even necessary? I think the below wi
qsr 2014/05/20 11:58:31 Yes, but it does a few SendCommand, and maybe a sh
+ # Ignore result.
+ adb.EnableAdbRoot()
if sys.platform.startswith('linux'):
# Host side workaround for crbug.com/268450 (adb instability)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698