[CrOS Tether] Network detail settings page: Do not show irrelevant fields for Tether networks.

chrome/browser/resources/settings/internet_page/internet_detail_page.js

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index ce8553d223b4e417441cc36678ed3c30df158512..56a566ac3e055e73d7665a5802689a51ac49b6a7 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -928,6 +928,8 @@ Polymer({
    * @private
    */
   showAdvanced_: function(networkProperties) {
+    if (networkProperties.Type == CrOnc.Type.TETHER)
+      return false;

[stevenjb, 2017/06/22 22:29:19]

Modify getAdvancedFields_ instead (see above)

[Kyle Horimoto, 2017/06/22 23:03:00]

That's not good enough. When this network is connected,
isRememberedOrConnected_() still returns true and the section is displayed.

     return this.hasAdvancedFields_() || this.hasDeviceFields_() ||
         this.isRememberedOrConnected_(networkProperties);
   },
@@ -962,8 +964,10 @@ Polymer({
    * @private
    */
   hasNetworkSection_: function(networkProperties) {
-    if (networkProperties.Type == CrOnc.Type.VPN)
+    if (networkProperties.Type == CrOnc.Type.VPN ||
+        networkProperties.Type == CrOnc.Type.TETHER) {

[stevenjb, 2017/06/22 22:29:19]

This seems incorrect to me. Connected Tether networks still have IP config and
nameservers, especially since we are hiding the underlying wifi network; we
should extract that information from the wifi network instead.

[Kyle Horimoto, 2017/06/22 23:03:00]

As discussed offline, UX says we should not display this for now. Added a
comment for clarity. Maybe we can come back to this in v2 and display the Wi-Fi
network properties instead.

       return false;
+    }
     if (networkProperties.Type == CrOnc.Type.CELLULAR)
       return true;
     return this.isRememberedOrConnected_(networkProperties);

[stevenjb, 2017/06/22 22:29:19]

This logic may need to change though, we probably don't want to support
configuring the IP address of an unconnected Tether network. This could be:
if (type == tether)
  return this.isConnectedState_()

[Kyle Horimoto, 2017/06/22 23:03:00]

Acknowledged.