[CrOS Tether] Network detail settings page: Do not show irrelevant fields for Tether networks.

chrome/browser/resources/settings/internet_page/internet_detail_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-detail' is the settings subpage containing details
  * for a network.
  */
 (function() {
@@ skipping 868 matching lines @@
       fields.push('RestrictedConnectivity', 'WiMAX.EAP.Identity');
     }
     return fields;
   },
 
   /**
    * @return {!Array<string>} The fields to display in the Advanced section.
    * @private
    */
   getAdvancedFields_: function() {
     /** @type {!Array<string>} */ var fields = [];

[stevenjb, 2017/06/22 22:29:19]

+if (type != CrOnc.Type.TETHER)

[Kyle Horimoto, 2017/06/22 23:03:00]

Done.

     fields.push('MacAddress');
     var type = this.networkProperties.Type;
     if (type == CrOnc.Type.CELLULAR && !!this.networkProperties.Cellular) {
       fields.push(
           'Cellular.Carrier', 'Cellular.Family', 'Cellular.NetworkTechnology',
           'Cellular.ServingOperator.Code');
     } else if (type == CrOnc.Type.WI_FI) {
       fields.push(
           'WiFi.SSID', 'WiFi.BSSID', 'WiFi.SignalStrength', 'WiFi.Security',
           'WiFi.EAP.Outer', 'WiFi.EAP.Inner', 'WiFi.EAP.SubjectMatch',
@@ skipping 21 matching lines @@
     }
     return fields;
   },
 
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
    * @return {boolean}
    * @private
    */
   showAdvanced_: function(networkProperties) {
+    if (networkProperties.Type == CrOnc.Type.TETHER)
+      return false;

[stevenjb, 2017/06/22 22:29:19]

Modify getAdvancedFields_ instead (see above)

[Kyle Horimoto, 2017/06/22 23:03:00]

That's not good enough. When this network is connected,
isRememberedOrConnected_() still returns true and the section is displayed.

     return this.hasAdvancedFields_() || this.hasDeviceFields_() ||
         this.isRememberedOrConnected_(networkProperties);
   },
 
   /**
    * @return {boolean}
    * @private
    */
   hasAdvancedFields_: function() {
     return this.hasVisibleFields_(this.getAdvancedFields_());
@@ skipping 14 matching lines @@
   hasAdvancedOrDeviceFields_: function() {
     return this.hasAdvancedFields_() || this.hasDeviceFields_();
   },
 
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
    * @return {boolean}
    * @private
    */
   hasNetworkSection_: function(networkProperties) {
-    if (networkProperties.Type == CrOnc.Type.VPN)
+    if (networkProperties.Type == CrOnc.Type.VPN ||
+        networkProperties.Type == CrOnc.Type.TETHER) {

[stevenjb, 2017/06/22 22:29:19]

This seems incorrect to me. Connected Tether networks still have IP config and
nameservers, especially since we are hiding the underlying wifi network; we
should extract that information from the wifi network instead.

[Kyle Horimoto, 2017/06/22 23:03:00]

As discussed offline, UX says we should not display this for now. Added a
comment for clarity. Maybe we can come back to this in v2 and display the Wi-Fi
network properties instead.

       return false;
+    }
     if (networkProperties.Type == CrOnc.Type.CELLULAR)
       return true;
     return this.isRememberedOrConnected_(networkProperties);

[stevenjb, 2017/06/22 22:29:19]

This logic may need to change though, we probably don't want to support
configuring the IP address of an unconnected Tether network. This could be:
if (type == tether)
  return this.isConnectedState_()

[Kyle Horimoto, 2017/06/22 23:03:00]

Acknowledged.

   },
 
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
    * @return {boolean}
    * @private
    */
   showCellularSim_: function(networkProperties) {
     if (networkProperties.Type != 'Cellular' || !networkProperties.Cellular) {
       return false;
@@ skipping 12 matching lines @@
    */
   allPropertiesMatch_: function(curValue, newValue) {
     for (var key in newValue) {
       if (newValue[key] != curValue[key])
         return false;
     }
     return true;
   }
 });
 })();