runtime/bin/vmservice_impl.h - Issue 2949323002: Load vmservice from a .dill file when generating AOT snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice_impl.h

Issue 2949323002: Load vmservice from a .dill file when generating AOT snapshots. (Closed)

Patch Set: Address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice_impl.h

diff --git a/runtime/bin/vmservice_impl.h b/runtime/bin/vmservice_impl.h

index 1add3eb0dd2c7fbf23be24eb32b0e0e3904b0c3e..41ecd90ed2c12744071fca496e1606678eb0259c 100644

--- a/runtime/bin/vmservice_impl.h

+++ b/runtime/bin/vmservice_impl.h

@@ -14,7 +14,7 @@ namespace bin {

class VmService {

public:

- static bool LoadForGenPrecompiled();

+ static bool LoadForGenPrecompiled(void* vmservice_kernel);

static bool Setup(const char* server_ip,

intptr_t server_port,

« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/bin/vmservice_impl.cc » ('j') | no next file with comments »