Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 29493004: browser: Enable DockInfo for Aura Linux besides X11 (Closed)

Created:
7 years, 2 months ago by vignatti (out of this project)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank, dnicoara, rjkroege, ozone-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

browser: Enable DockInfo for Aura Linux besides X11 Currently DockInfo is supporting ChromeOS and Aura X11, but we want to enable it for Aura Ozone as well. This CL stubs DockInfo::GetLocalProcessWindowAtPoint for non-X11 based platforms and, in particular, this brings back support for Chrome browser in Ozone-Wayland. BUG=295089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231842

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : using auralinux.cc this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -226 lines) Patch
A + chrome/browser/ui/aura/tabs/dock_info_auralinux.cc View 1 2 4 chunks +24 lines, -15 lines 0 comments Download
D chrome/browser/ui/aura/tabs/dock_info_aurax11.cc View 1 2 1 chunk +0 lines, -210 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
vignatti (out of this project)
7 years, 2 months ago (2013-10-23 13:55:59 UTC) #1
Ben Goodger (Google)
https://codereview.chromium.org/29493004/diff/1/chrome/browser/ui/aura/tabs/dock_info_aura.cc File chrome/browser/ui/aura/tabs/dock_info_aura.cc (right): https://codereview.chromium.org/29493004/diff/1/chrome/browser/ui/aura/tabs/dock_info_aura.cc#newcode200 chrome/browser/ui/aura/tabs/dock_info_aura.cc:200: gfx::NativeView DockInfo::GetLocalProcessWindowAtPoint( shouldn't this be in #else?
7 years, 2 months ago (2013-10-23 17:39:28 UTC) #2
vignatti (out of this project)
PTAL. Thanks! https://codereview.chromium.org/29493004/diff/1/chrome/browser/ui/aura/tabs/dock_info_aura.cc File chrome/browser/ui/aura/tabs/dock_info_aura.cc (right): https://codereview.chromium.org/29493004/diff/1/chrome/browser/ui/aura/tabs/dock_info_aura.cc#newcode200 chrome/browser/ui/aura/tabs/dock_info_aura.cc:200: gfx::NativeView DockInfo::GetLocalProcessWindowAtPoint( On 2013/10/23 17:39:28, Ben Goodger ...
7 years, 2 months ago (2013-10-24 07:46:20 UTC) #3
Ben Goodger (Google)
lgtm
7 years, 2 months ago (2013-10-24 16:42:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/29493004/60001
7 years, 1 month ago (2013-10-25 07:48:20 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-25 09:42:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/29493004/60001
7 years, 1 month ago (2013-10-25 14:50:33 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-25 15:59:29 UTC) #8
vignatti (out of this project)
On 2013/10/25 15:59:29, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
7 years, 1 month ago (2013-10-28 10:11:38 UTC) #9
Ben Goodger (Google)
yeah ok
7 years, 1 month ago (2013-10-28 17:37:01 UTC) #10
vignatti (out of this project)
On 2013/10/28 17:37:01, Ben Goodger (Google) wrote: > yeah ok ok, I'll wait first for ...
7 years, 1 month ago (2013-10-29 09:27:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/29493004/400001
7 years, 1 month ago (2013-10-30 12:22:16 UTC) #12
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-10-30 15:32:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/29493004/400001
7 years, 1 month ago (2013-10-30 15:48:52 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 15:51:13 UTC) #15
Message was sent while issue was closed.
Change committed as 231842

Powered by Google App Engine
This is Rietveld 408576698