Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2949293002: Add ScopeInfo class for variable information that doesn't actually involve closures. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/locals_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 3b99d41a9118892dca5ed2581417a263c1eec67b..535bdb478b65979e27e6e0309ec76b4e091b45ad 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -605,13 +605,13 @@ class KernelSsaGraphBuilder extends ir.Visitor
// Set the locals handler state as if we were inlining the constructor.
ConstructorEntity astElement = _elementMap.getConstructor(constructor);
- ClosureRepresentationInfo oldClosureData = localsHandler.closureData;
- ClosureRepresentationInfo newClosureData =
- closureDataLookup.getClosureRepresentationInfo(astElement);
+ ClosureRepresentationInfo oldScopeInfo = localsHandler.scopeInfo;
+ ClosureRepresentationInfo newScopeInfo =
+ closureDataLookup.getScopeInfo(astElement);
if (astElement is ConstructorElement) {
// TODO(johnniwinther): Support constructor (body) entities.
ResolvedAst resolvedAst = astElement.resolvedAst;
- localsHandler.closureData = newClosureData;
+ localsHandler.scopeInfo = newScopeInfo;
if (resolvedAst.kind == ResolvedAstKind.PARSED) {
localsHandler.enterScope(
closureDataLookup.getClosureAnalysisInfo(resolvedAst.node),
@@ -622,7 +622,7 @@ class KernelSsaGraphBuilder extends ir.Visitor
inlinedFrom(astElement, () {
_buildInitializers(constructor, constructorChain, fieldValues);
});
- localsHandler.closureData = oldClosureData;
+ localsHandler.scopeInfo = oldScopeInfo;
}
/// Builds generative constructor body.
@@ -705,7 +705,7 @@ class KernelSsaGraphBuilder extends ir.Visitor
localsHandler.startFunction(
targetElement,
- closureDataLookup.getClosureRepresentationInfo(targetElement),
+ closureDataLookup.getScopeInfo(targetElement),
closureDataLookup.getClosureAnalysisInfo(functionNode),
parameterMap,
isGenerativeConstructorBody: _targetIsConstructorBody);
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/locals_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698