Add ScopeInfo class for variable information that doesn't actually involve closures.

Add ScopeInfo class for variable information that doesn't actually involve closures.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b3812ffc8ecc1f4ea43f4611fc76f078489ddbff

[Emily Fortuna, 2017-06-22 21:37:42]

Patchset #3 (id:40001) has been deleted

[Emily Fortuna, 2017-06-22 21:37:47]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-06-22 21:37:52]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-06-22 21:54:21]

Patchset #1 (id:60001) has been deleted

[Emily Fortuna, 2017-06-22 21:54:50]

Description was changed from

==========
Scope class.

BUG=
==========

to

==========
Add ScopeInfo class for variable information that doesn't actually involve
closures.

BUG=
==========

[Emily Fortuna, 2017-06-22 21:54:50]

efortuna@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-23 19:11:56]

lgtm

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (left):

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:183: bool variableIsUsedInTryOrSync(Local
variable) => false;
I think it's fine either way, but what I liked about having this bool-API is
that the `Set` implementation was hidden from consumers of this info.

It makes sense to expose the set so you can directly add to it in the
kernel-specific implementation though. So I can see that this API provides less
value now that the set is exposed.

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:85: final Set<Local> variablesUsedInTryOrSync
= const UnmodifiableSetView.empty();
I lean towards simply using `new Set<Local>()` here instead and drop the
dependency on package:collection.

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:716: final Set<Local> variablesUsedInTryOrSync
= new Set<Local>();
alternatively, we could change "implements ClosureRepresentationInfo" to
"extends ...", and use the field from the supersuperclass

[Emily Fortuna, 2017-06-23 21:20:06]

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (left):

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:183: bool variableIsUsedInTryOrSync(Local
variable) => false;
On 2017/06/23 19:11:56, Siggi Cherem (dart-lang) wrote:
> I think it's fine either way, but what I liked about having this bool-API is
> that the `Set` implementation was hidden from consumers of this info.
> 
> It makes sense to expose the set so you can directly add to it in the
> kernel-specific implementation though. So I can see that this API provides
less
> value now that the set is exposed.

Moved back to the API it was!

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:85: final Set<Local> variablesUsedInTryOrSync
= const UnmodifiableSetView.empty();
On 2017/06/23 19:11:56, Siggi Cherem (dart-lang) wrote:
> I lean towards simply using `new Set<Local>()` here instead and drop the
> dependency on package:collection.

switched to old API!

https://codereview.chromium.org/2949293002/diff/80001/pkg/compiler/lib/src/cl...
pkg/compiler/lib/src/closure.dart:716: final Set<Local> variablesUsedInTryOrSync
= new Set<Local>();
On 2017/06/23 19:11:56, Siggi Cherem (dart-lang) wrote:
> alternatively, we could change "implements ClosureRepresentationInfo" to
> "extends ...", and use the field from the supersuperclass

Acknowledged.

[Emily Fortuna, 2017-06-23 21:20:28]

Description was changed from

==========
Add ScopeInfo class for variable information that doesn't actually involve
closures.

BUG=
==========

to

==========
Add ScopeInfo class for variable information that doesn't actually involve
closures.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b3812ffc8ecc1f4ea43f4611fc76f078489ddbff
==========

[Emily Fortuna, 2017-06-23 21:20:29]

Committed patchset #2 (id:100001) manually as
b3812ffc8ecc1f4ea43f4611fc76f078489ddbff (presubmit successful).