Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: components/rlz/rlz_tracker_unittest.cc

Issue 2949263003: Remove call to GetBlockingPool in RLZ (Closed)
Patch Set: Use PostDelayedTaskWithTraits Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rlz/rlz_tracker_delegate.h ('k') | ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rlz/rlz_tracker_unittest.cc
diff --git a/components/rlz/rlz_tracker_unittest.cc b/components/rlz/rlz_tracker_unittest.cc
index 937bb4f7d8d0097110cb66a4226db69a0268f232..20c54fe3ed0c1d6b5d76a238d2adb41c733bb788 100644
--- a/components/rlz/rlz_tracker_unittest.cc
+++ b/components/rlz/rlz_tracker_unittest.cc
@@ -11,7 +11,7 @@
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/test/sequenced_worker_pool_owner.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "build/build_config.h"
@@ -34,8 +34,7 @@ namespace {
class TestRLZTrackerDelegate : public RLZTrackerDelegate {
public:
TestRLZTrackerDelegate()
- : worker_pool_owner_(2, "TestRLZTracker"),
- request_context_getter_(new net::TestURLRequestContextGetter(
+ : request_context_getter_(new net::TestURLRequestContextGetter(
base::ThreadTaskRunnerHandle::Get())) {}
void set_brand(const char* brand) { brand_override_ = brand; }
@@ -69,10 +68,6 @@ class TestRLZTrackerDelegate : public RLZTrackerDelegate {
bool IsOnUIThread() override { return true; }
- base::SequencedWorkerPool* GetBlockingPool() override {
- return worker_pool_owner_.pool().get();
- }
-
net::URLRequestContextGetter* GetRequestContext() override {
return request_context_getter_.get();
}
@@ -110,7 +105,6 @@ class TestRLZTrackerDelegate : public RLZTrackerDelegate {
}
private:
- base::SequencedWorkerPoolOwner worker_pool_owner_;
scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
std::string brand_override_;
@@ -257,7 +251,7 @@ class RlzLibTest : public testing::Test {
void ExpectRlzPingSent(bool expected);
void ExpectReactivationRlzPingSent(bool expected);
- base::MessageLoop message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
TestRLZTrackerDelegate* delegate_;
std::unique_ptr<TestRLZTracker> tracker_;
RlzLibTestNoMachineStateHelper m_rlz_test_helper_;
« no previous file with comments | « components/rlz/rlz_tracker_delegate.h ('k') | ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698