Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: printing/printing_context.cc

Issue 294923005: Add media size capability to PDF printer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('K') | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context.cc
diff --git a/printing/printing_context.cc b/printing/printing_context.cc
index 817d59c93b283cc974b581b78e03cd364356ef01..c68571ba455189ec768051a655d8ace4b899e22e 100644
--- a/printing/printing_context.cc
+++ b/printing/printing_context.cc
@@ -85,7 +85,8 @@ PrintingContext::Result PrintingContext::UpdatePrintSettings(
if (media_size->GetInteger(kSettingMediaSizeWidthMicrons,
&width_microns) &&
media_size->GetInteger(kSettingMediaSizeHeightMicrons,
- &height_microns)) {
+ &height_microns) &&
+ settings_.device_units_per_inch() > 0) {
Vitaly Buka (NO REVIEWS) 2014/05/20 22:52:19 how is this possible?
float deviceMicronsPerDeviceUnit =
(kHundrethsMMPerInch * 10.0f) / settings_.device_units_per_inch();
paper_size = gfx::Size(width_microns / deviceMicronsPerDeviceUnit,
« chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('K') | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698