Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294923005: Add media size capability to PDF printer. (Closed)

Created:
6 years, 7 months ago by Aleksey Shlyapnikov
Modified:
4 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Add media size capability to PDF printer. BUG=239879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273491

Patch Set 1 #

Total comments: 9

Patch Set 2 : Retrieve PDF printer capabilites via the same API as for any other local printer. #

Total comments: 12

Patch Set 3 : Address cl comments. #

Patch Set 4 : Fix PrintPreviewWebUITest.PrintToPDFSelectedHideFitToPageOption and address other cl comments. #

Patch Set 5 : Gracefully stop pending print queries upon shutdown. #

Total comments: 2

Patch Set 6 : Add a comment to the new query stopping code. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -99 lines) Patch
M chrome/browser/printing/print_job_manager.cc View 1 2 3 4 5 1 chunk +14 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/data/app_state.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/data/destination_store.js View 1 2 3 4 chunks +60 lines, -40 lines 2 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.js View 1 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 11 chunks +104 lines, -15 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 2 3 1 chunk +28 lines, -16 lines 0 comments Download
M components/cloud_devices/common/cloud_device_description.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/cloud_devices/common/printer_description.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/cloud_devices/common/printer_description.cc View 1 2 4 chunks +24 lines, -4 lines 0 comments Download
M printing/printing_context.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M printing/printing_context.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (1 generated)
Aleksey Shlyapnikov
6 years, 7 months ago (2014-05-20 22:26:48 UTC) #1
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/294923005/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/294923005/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode734 chrome/browser/resources/print_preview/data/destination_store.js:734: if (this.destinations_[0] && Why do you need this if? ...
6 years, 7 months ago (2014-05-20 22:52:18 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2014/05/20 22:52:18, Vitaly Buka wrote: > https://codereview.chromium.org/294923005/diff/1/chrome/browser/resources/print_preview/data/destination_store.js > File chrome/browser/resources/print_preview/data/destination_store.js (right): > > https://codereview.chromium.org/294923005/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode734 ...
6 years, 7 months ago (2014-05-20 22:59:41 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/294923005/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/294923005/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode295 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:295: pdf_settings->SetBoolean(printing::kSettingLandscape, false); move to context https://codereview.chromium.org/294923005/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode366 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:366: if (max_diff ...
6 years, 7 months ago (2014-05-20 23:53:01 UTC) #4
Aleksey Shlyapnikov
https://codereview.chromium.org/294923005/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/294923005/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode295 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:295: pdf_settings->SetBoolean(printing::kSettingLandscape, false); On 2014/05/20 23:53:02, Vitaly Buka wrote: > ...
6 years, 7 months ago (2014-05-22 00:08:14 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/294923005/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/294923005/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode318 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:318: cloud_devices::CloudDeviceDescription description; use namespace cloud_devices::printer; https://codereview.chromium.org/294923005/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode353 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:353: return ...
6 years, 7 months ago (2014-05-22 01:11:20 UTC) #6
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-22 01:12:22 UTC) #7
Aleksey Shlyapnikov
https://codereview.chromium.org/294923005/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/294923005/diff/20001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode318 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:318: cloud_devices::CloudDeviceDescription description; On 2014/05/22 01:11:21, Vitaly Buka wrote: > ...
6 years, 7 months ago (2014-05-22 03:51:17 UTC) #8
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 7 months ago (2014-05-22 03:51:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/294923005/40001
6 years, 7 months ago (2014-05-22 03:53:53 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 09:59:03 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:55:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/34115)
6 years, 7 months ago (2014-05-22 10:55:52 UTC) #13
Aleksey Shlyapnikov
6 years, 7 months ago (2014-05-22 23:22:27 UTC) #14
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 7 months ago (2014-05-22 23:25:57 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 02:38:56 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 03:53:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/30366)
6 years, 7 months ago (2014-05-23 03:53:10 UTC) #18
Aleksey Shlyapnikov
PTAL
6 years, 6 months ago (2014-05-28 23:29:47 UTC) #19
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 6 months ago (2014-05-29 00:50:21 UTC) #20
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/294923005/diff/80001/chrome/browser/printing/print_job_manager.cc File chrome/browser/printing/print_job_manager.cc (right): https://codereview.chromium.org/294923005/diff/80001/chrome/browser/printing/print_job_manager.cc#newcode67 chrome/browser/printing/print_job_manager.cc:67: itr != queries_to_stop.end(); ++itr) { iterating using for ...
6 years, 6 months ago (2014-05-29 00:58:34 UTC) #21
Aleksey Shlyapnikov
The CQ bit was unchecked by alekseys@chromium.org
6 years, 6 months ago (2014-05-29 00:58:37 UTC) #22
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 6 months ago (2014-05-29 01:12:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/294923005/90001
6 years, 6 months ago (2014-05-29 01:13:14 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 05:59:07 UTC) #25
commit-bot: I haz the power
Change committed as 273491
6 years, 6 months ago (2014-05-29 16:32:52 UTC) #26
Lei Zhang
https://codereview.chromium.org/294923005/diff/90001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/294923005/diff/90001/chrome/browser/resources/print_preview/data/destination_store.js#newcode210 chrome/browser/resources/print_preview/data/destination_store.js:210: 'NA_LEDGER': 'Tabloid' Question - why is NA_LEDGER translated into ...
4 years, 2 months ago (2016-10-22 02:09:48 UTC) #28
Aleksey Shlyapnikov
https://codereview.chromium.org/294923005/diff/90001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/294923005/diff/90001/chrome/browser/resources/print_preview/data/destination_store.js#newcode210 chrome/browser/resources/print_preview/data/destination_store.js:210: 'NA_LEDGER': 'Tabloid' On 2016/10/22 02:09:48, Lei Zhang wrote: > ...
4 years, 2 months ago (2016-10-22 02:28:09 UTC) #29
Lei Zhang
4 years, 1 month ago (2016-10-24 20:58:43 UTC) #30
Message was sent while issue was closed. 
On 2016/10/22 02:28:09, Aleksey Shlyapnikov wrote:
> Those NA_ names come from CDD
> (https://developers.google.com/cloud-print/docs/cdd) and the only value there
> referring to media sized 11 by 17 inches, landscape or portrait, is NA_LEDGER.
> Now, Ledger is landscape, but Chrome default is portrait orientation, and
11x17
> portrait media is called Tabloid, hence the choice of the name.

Thanks for the explanation.

Powered by Google App Engine
This is Rietveld 408576698