[Android] Fix context menu animation errors for Browser Actions

chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.widget;
 
 import android.app.Activity;
 import android.graphics.Color;
 import android.graphics.Rect;
 import android.graphics.drawable.ColorDrawable;
 import android.support.v4.view.animation.LinearOutSlowInInterpolator;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.View.OnLayoutChangeListener;
 import android.view.ViewGroup;
 import android.view.ViewGroup.LayoutParams;
 import android.view.Window;
 import android.view.animation.Animation;
 import android.view.animation.Animation.AnimationListener;
 import android.view.animation.ScaleAnimation;
 
 import org.chromium.chrome.browser.contextmenu.TabularContextMenuViewPager;
 import org.chromium.content.browser.RenderCoordinates;
 
+import javax.annotation.Nullable;
+
 /**
  * ContextMenuDialog is a subclass of AlwaysDismissedDialog that ensures that the proper scale
  * animation is played upon calling {@link #show()} and {@link #dismiss()}.
  */
 public class ContextMenuDialog extends AlwaysDismissedDialog {
     private static final long ENTER_ANIMATION_DURATION_MS = 250;
     // Exit animation duration should be set to 60% of the enter animation duration.
     private static final long EXIT_ANIMATION_DURATION_MS = 150;
 
     private final Activity mActivity;
     private final View mContentView;
     private final float mTouchPointXPx;
     private final float mTouchPointYPx;
     private final RenderCoordinates mRenderCoordinates;
 
     private float mContextMenuSourceXPx;
     private float mContextMenuSourceYPx;
     private int mContextMenuFirstLocationYPx;
 
     /**
      * Creates an instance of the ContextMenuDialog.
      * @param ownerActivity The activity in which the dialog should run
      * @param theme A style resource describing the theme to use for the window, or {@code 0} to use
      *              the default dialog theme
      * @param touchPointXPx The x-coordinate of the touch that triggered the context menu.
      * @param touchPointYPx The y-coordinate of the touch that triggered the context menu.
      * @param contentView The The {@link TabularContextMenuViewPager} to display on the dialog.
-     * @param renderCoordinates The render coordinates to get the y offset of the window.
+     * @param renderCoordinates The render coordinates to get the y offset of the window. This could
+     *                          be null if ContentViewCore is not available.
      */
     public ContextMenuDialog(Activity ownerActivity, int theme, float touchPointXPx,
-            float touchPointYPx, View contentView, RenderCoordinates renderCoordinates) {
+            float touchPointYPx, View contentView, @Nullable RenderCoordinates renderCoordinates) {
         super(ownerActivity, theme);
         mActivity = ownerActivity;
         mTouchPointXPx = touchPointXPx;
         mTouchPointYPx = touchPointYPx;
         mContentView = contentView;
         mRenderCoordinates = renderCoordinates;
     }
 
     @Override
     public void show() {
@@ skipping 22 matching lines @@
         });
         super.show();
     }
 
     private void startEnterAnimation() {
         Rect rectangle = new Rect();
         Window window = mActivity.getWindow();
         window.getDecorView().getWindowVisibleDisplayFrame(rectangle);
 
         float xOffsetPx = rectangle.left;
-        float yOffsetPx = rectangle.top + mRenderCoordinates.getContentOffsetYPix();
+        float contentOffsetYPx =
+                mRenderCoordinates != null ? mRenderCoordinates.getContentOffsetYPix() : 0;
+        float yOffsetPx = rectangle.top + contentOffsetYPx;
 
         int[] currentLocationOnScreenPx = new int[2];
         mContentView.getLocationOnScreen(currentLocationOnScreenPx);
 
         mContextMenuFirstLocationYPx = currentLocationOnScreenPx[1];
 
         mContextMenuSourceXPx = mTouchPointXPx - currentLocationOnScreenPx[0] + xOffsetPx;
         mContextMenuSourceYPx = mTouchPointYPx - currentLocationOnScreenPx[1] + yOffsetPx;
 
         Animation animation = getScaleAnimation(true, mContextMenuSourceXPx, mContextMenuSourceYPx);
@@ skipping 43 matching lines @@
      * @param pivotY The Y coordinate of the point about which the object is being scaled, specified
      *               as an absolute number where 0 is the top edge.
      * @return Returns the scale animation for the context menu.
      */
     public Animation getScaleAnimation(boolean isEnterAnimation, float pivotX, float pivotY) {
         float fromX = isEnterAnimation ? 0f : 1f;
         float toX = isEnterAnimation ? 1f : 0f;
         float fromY = fromX;
         float toY = toX;
 
-        ScaleAnimation animation = new ScaleAnimation(
-                fromX, toX, fromY, toY, Animation.ABSOLUTE, pivotX, Animation.ABSOLUTE, pivotY);
+        ScaleAnimation animation;
+        if (mRenderCoordinates == null) {
+            animation = new ScaleAnimation(fromX, toX, fromY, toY, Animation.RELATIVE_TO_SELF, 0.5f,
+                    Animation.RELATIVE_TO_SELF, 0.5f);

[Theresa, 2017/06/22 23:33:41]

I think ideally we would skip calculating the pivot points if we're not going to
use them, but I'm okay with this.

+        } else {
+            animation = new ScaleAnimation(
+                    fromX, toX, fromY, toY, Animation.ABSOLUTE, pivotX, Animation.ABSOLUTE, pivotY);
+        }
 
         long duration = isEnterAnimation ? ENTER_ANIMATION_DURATION_MS : EXIT_ANIMATION_DURATION_MS;
 
         animation.setDuration(duration);
         animation.setInterpolator(new LinearOutSlowInInterpolator());
         return animation;
     }
 }