tools/json_schema_compiler/idl_schema.py - Issue 2949143002: [Extensions Bindings] Support ArrayBufferView in idl files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/idl_schema.py

Issue 2949143002: [Extensions Bindings] Support ArrayBufferView in idl files (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/idl_schema.py

diff --git a/tools/json_schema_compiler/idl_schema.py b/tools/json_schema_compiler/idl_schema.py

index 7bbe84246768df23684c6ed6f9784f6c238e7bb5..125e5bd481f246a31d8b79e7127478175626ace9 100755

--- a/tools/json_schema_compiler/idl_schema.py

+++ b/tools/json_schema_compiler/idl_schema.py

@@ -315,6 +315,10 @@ class Typeref(object):

elif self.typeref == 'ArrayBuffer':

properties['type'] = 'binary'

properties['isInstanceOf'] = 'ArrayBuffer'

+ elif self.typeref == 'ArrayBufferView':

+ properties['type'] = 'binary'

+ # We force the APIs to specify instanceOf since ArrayBufferView isn't an

lazyboy 2017/06/24 00:53:16 nit: also add: therefore we don't specify instance

Devlin 2017/06/24 02:05:26 Done.

+ # instantiable type.

elif self.typeref == 'FileEntry':

properties['type'] = 'object'

properties['isInstanceOf'] = 'FileEntry'