Issue 2949123002: Fix mocked operator methods

Issue 2949123002: Fix mocked operator methods (Closed)

Created:
3 years, 6 months ago by vsm

Modified:
3 years, 6 months ago

Reviewers:
Jacob, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix mocked operator methods R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/febded6052b54615ac67128d05fceb6673e45a6e

Patch Set 1 #

Total comments: 1

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	tests/lib_strong/html/html_mock_test.dart	View		3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as febded6052b54615ac67128d05fceb6673e45a6e (presubmit successful).

3 years, 6 months ago (2017-06-21 23:54:21 UTC) #5

Jennifer Messerly

3 years, 6 months ago (2017-06-22 20:26:31 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/2949123002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2949123002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1533:
_declareMemberName(method, useDisplayName: false),
fyi ... useDisplayName defaults to false and does not appear to be used. I'll
send a CL sending a cleanup

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages