third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2949073002: Changing scroll and view state in onpopstate shouldn't overwrite back/forward state restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2949073002: Changing scroll and view state in onpopstate shouldn't overwrite back/forward state restore (Closed)

Patch Set: Reset ViewState when trying to copy from a nullptr Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index a33f94d43c7a650b2f12573c978b9e50744516e8..540a505e478c491d0d5e0a6b447e12a89602bb16 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -2448,7 +2448,8 @@ TEST_P(ParameterizedWebFrameTest, pageScaleFactorWrittenToHistoryItem) {

->Loader()

.GetDocumentLoader()

->GetHistoryItem()

- ->PageScaleFactor());

+ ->GetViewState()

+ ->page_scale_factor_);

}

TEST_P(ParameterizedWebFrameTest, initialScaleWrittenToHistoryItem) {

@@ -2474,7 +2475,8 @@ TEST_P(ParameterizedWebFrameTest, initialScaleWrittenToHistoryItem) {