third_party/WebKit/Source/core/loader/FrameLoader.h - Issue 2949073002: Changing scroll and view state in onpopstate shouldn't overwrite back/forward state restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.h

Issue 2949073002: Changing scroll and view state in onpopstate shouldn't overwrite back/forward state restore (Closed)

Patch Set: Reset ViewState when trying to copy from a nullptr Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.h

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.h b/third_party/WebKit/Source/core/loader/FrameLoader.h

index d8f5b92a5f999d630d396b924466b803ef0b9933..209dd869cc5b8d4c045e9733d6b273ed371068ea 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.h

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.h

@@ -245,8 +245,10 @@ class CORE_EXPORT FrameLoader final {

HistoryItem*,

ClientRedirectPolicy,

Document*);

- void RestoreScrollPositionAndViewStateForLoadType(FrameLoadType,

- HistoryLoadType);

+ void RestoreScrollPositionAndViewState(FrameLoadType,

+ HistoryLoadType,

+ HistoryItem::ViewState*,

+ HistoryScrollRestorationType);

void ScheduleCheckCompleted();