Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.h

Issue 2949073002: Changing scroll and view state in onpopstate shouldn't overwrite back/forward state restore (Closed)
Patch Set: +test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.h
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.h b/third_party/WebKit/Source/core/loader/FrameLoader.h
index 0827dc3d185f638a74bdcb9d99cdd74e7db1339e..ee40c1c0d01b300ef6599a3c65db77b6c1f9fad6 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.h
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.h
@@ -247,7 +247,10 @@ class CORE_EXPORT FrameLoader final {
HistoryItem*,
ClientRedirectPolicy,
Document*);
- void RestoreScrollPositionAndViewStateForLoadType(FrameLoadType);
+ void RestoreScrollPositionAndViewStateForLoadType(
majidvp 2017/06/26 16:19:26 nit: Given that load type is no longer the sole ar
Nate Chapin 2017/07/11 22:17:59 Dropped "ForLoadType", which leaves multiple funct
+ FrameLoadType,
+ HistoryItem::ScrollAndViewState*,
+ HistoryScrollRestorationType);
void ScheduleCheckCompleted();

Powered by Google App Engine
This is Rietveld 408576698