Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: content/browser/presentation/presentation_service_impl.h

Issue 2949053002: [Presentation API] OffscreenPresentationManager should only interact with top level receiver frame (Closed)
Patch Set: resolve code review comments from ncarter Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_
6 #define CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_ 6 #define CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 pending_reconnect_presentation_cbs_; 271 pending_reconnect_presentation_cbs_;
272 272
273 // RAII binding of |this| to an Presentation interface request. 273 // RAII binding of |this| to an Presentation interface request.
274 // The binding is removed when binding_ is cleared or goes out of scope. 274 // The binding is removed when binding_ is cleared or goes out of scope.
275 std::unique_ptr<mojo::Binding<blink::mojom::PresentationService>> binding_; 275 std::unique_ptr<mojo::Binding<blink::mojom::PresentationService>> binding_;
276 276
277 // ID of the RenderFrameHost this object is associated with. 277 // ID of the RenderFrameHost this object is associated with.
278 int render_process_id_; 278 int render_process_id_;
279 int render_frame_id_; 279 int render_frame_id_;
280 280
281 // If current frame is top level frame.
282 bool is_main_frame_;
283
281 // NOTE: Weak pointers must be invalidated before all other member variables. 284 // NOTE: Weak pointers must be invalidated before all other member variables.
282 base::WeakPtrFactory<PresentationServiceImpl> weak_factory_; 285 base::WeakPtrFactory<PresentationServiceImpl> weak_factory_;
283 286
284 DISALLOW_COPY_AND_ASSIGN(PresentationServiceImpl); 287 DISALLOW_COPY_AND_ASSIGN(PresentationServiceImpl);
285 }; 288 };
286 289
287 } // namespace content 290 } // namespace content
288 291
289 #endif // CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_ 292 #endif // CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698