[Presentation API] OffscreenPresentationManager should only interact with top level receiver frame

content/browser/presentation/presentation_service_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/presentation/presentation_service_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <algorithm>
 #include <utility>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
+#include "content/browser/frame_host/frame_tree_node.h"
+#include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/common/presentation_connection_message.h"
 
 namespace content {
@@ skipping 28 matching lines @@
       controller_delegate_(controller_delegate),
       receiver_delegate_(receiver_delegate),
       start_presentation_request_id_(kInvalidRequestId),
       weak_factory_(this) {
   DCHECK(render_frame_host);
   DCHECK(web_contents);
   CHECK(render_frame_host->IsRenderFrameLive());
 
   render_process_id_ = render_frame_host->GetProcess()->GetID();
   render_frame_id_ = render_frame_host->GetRoutingID();
-  DVLOG(2) << "PresentationServiceImpl: "
-           << render_process_id_ << ", " << render_frame_id_;
+  auto* rfh_impl = static_cast<RenderFrameHostImpl*>(render_frame_host);
+  is_main_frame_ = rfh_impl->frame_tree_node()->IsMainFrame();

[ncarter (slow), 2017/06/23 19:49:01]

I forgot -- you can do this without the cast by just calling

render_frame_host->GetParent() != nullptr

However, the IsMainFrame() approach is totally fine too. They're equivalent.

[ncarter (slow), 2017/06/23 19:49:33]

(no parent means yes main frame)

[zhaobin, 2017/06/23 21:34:12]

Done.

+
+  DVLOG(2) << "PresentationServiceImpl: " << render_process_id_ << ", "
+           << render_frame_id_ << " is main frame: " << is_main_frame_;
 
   if (auto* delegate = GetPresentationServiceDelegate())
     delegate->AddObserver(render_process_id_, render_frame_id_, this);
 }
 
 PresentationServiceImpl::~PresentationServiceImpl() {
   DVLOG(2) << __FUNCTION__ << ": " << render_process_id_ << ", "
            << render_frame_id_;
 
   if (auto* delegate = GetPresentationServiceDelegate())
@@ skipping 33 matching lines @@
   binding_.reset(new mojo::Binding<blink::mojom::PresentationService>(
       this, std::move(request)));
 }
 
 void PresentationServiceImpl::SetClient(
     blink::mojom::PresentationServiceClientPtr client) {
   DCHECK(!client_.get());
   // TODO(imcheng): Set ErrorHandler to listen for errors.
   client_ = std::move(client);
 
-  if (receiver_delegate_) {
+  if (receiver_delegate_ && is_main_frame_) {
     receiver_delegate_->RegisterReceiverConnectionAvailableCallback(
         base::Bind(&PresentationServiceImpl::OnReceiverConnectionAvailable,
                    weak_factory_.GetWeakPtr()));
   }
 }
 
 void PresentationServiceImpl::ListenForScreenAvailability(const GURL& url) {
   DVLOG(2) << "ListenForScreenAvailability " << url.spec();
   if (!controller_delegate_) {
     client_->OnScreenAvailabilityUpdated(
@@ skipping 293 matching lines @@
   LOG(ERROR) << "PresentationServiceImpl is being deleted in "
              << "WebContentsDestroyed()! This shouldn't happen since it "
              << "should've been deleted during RenderFrameDeleted().";
   Reset();
   delete this;
 }
 
 void PresentationServiceImpl::Reset() {
   DVLOG(2) << "PresentationServiceImpl::Reset";
 
-  if (auto* delegate = GetPresentationServiceDelegate())
-    delegate->Reset(render_process_id_, render_frame_id_);
+  if (controller_delegate_)
+    controller_delegate_->Reset(render_process_id_, render_frame_id_);
+
+  if (receiver_delegate_ && is_main_frame_)
+    receiver_delegate_->Reset(render_process_id_, render_frame_id_);
 
   default_presentation_urls_.clear();
 
   screen_availability_listeners_.clear();
 
   start_presentation_request_id_ = kInvalidRequestId;
   pending_start_presentation_cb_.reset();
 
   pending_reconnect_presentation_cbs_.clear();
 }
@@ skipping 46 matching lines @@
 }
 
 void PresentationServiceImpl::NewPresentationCallbackWrapper::Run(
     const base::Optional<PresentationInfo>& presentation_info,
     const base::Optional<PresentationError>& error) {
   DCHECK(!callback_.is_null());
   std::move(callback_).Run(presentation_info, error);
 }
 
 }  // namespace content