Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

Issue 294903014: [DevTools] Add toolbox web contents to show in undocked mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
index c850488c81c410513302d3c15f6e1de7f372f7f2..33c5b9c6502c77745d0bd9c8ea1effd0a2dca96a 100644
--- a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
@@ -32,17 +32,17 @@ class DevToolsControllerTest : public InProcessBrowserTest {
IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, AllowOverlappingViews) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
- DevToolsWindow* dev_tools =
- DevToolsWindow::GetDockedInstanceForInspectedTab(web_contents);
+ content::WebContents* dev_tools =
+ DevToolsWindow::GetInTabWebContents(web_contents, NULL);
// Without the find bar.
- EXPECT_TRUE(dev_tools->web_contents()->GetAllowOverlappingViews());
+ EXPECT_TRUE(dev_tools->GetAllowOverlappingViews());
// With the find bar.
browser()->GetFindBarController()->find_bar()->Show(false);
- EXPECT_TRUE(dev_tools->web_contents()->GetAllowOverlappingViews());
+ EXPECT_TRUE(dev_tools->GetAllowOverlappingViews());
// Without the find bar.
browser()->GetFindBarController()->find_bar()->Hide(false);
- EXPECT_TRUE(dev_tools->web_contents()->GetAllowOverlappingViews());
+ EXPECT_TRUE(dev_tools->GetAllowOverlappingViews());
}

Powered by Google App Engine
This is Rietveld 408576698