Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5619)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 294903014: [DevTools] Add toolbox web contents to show in undocked mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mac fixes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 3ca80212125480e06ec920c250f82a07c23a9854..d9f7d03140273d1a5e70b4fa57ca833e3451e42b 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -1000,12 +1000,10 @@ willPositionSheet:(NSWindow*)sheet
allowOverlappingViews = YES;
contents->SetAllowOverlappingViews(allowOverlappingViews);
- DevToolsWindow* devToolsWindow =
- DevToolsWindow::GetDockedInstanceForInspectedTab(contents);
- if (devToolsWindow) {
- devToolsWindow->web_contents()->
- SetAllowOverlappingViews(allowOverlappingViews);
- }
+ WebContents* devTools =
+ DevToolsWindow::GetWebContentsToShowForInspectedTab(contents, NULL);
+ if (devTools)
+ devTools->SetAllowOverlappingViews(allowOverlappingViews);
}
- (void)updateInfoBarTipVisibility {
« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698