Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3819)

Unified Diff: chrome/browser/io_thread.cc

Issue 294903011: Default to disabling consistent port suggestion in QUIC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index adabf01dec251aab966cffdf29e3a268cb11c825..00ff6db20f689a17f64c71d0a34b222c5e2dbc4a 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -1111,24 +1111,7 @@ bool IOThread::ShouldEnableQuicPortSelection(
if (command_line.HasSwitch(switches::kEnableQuicPortSelection))
return true;
-#if defined(OS_WIN)
- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
- // Avoid picking ports (which might induce a security dialog) when we have a
- // beta or stable release. Allow in all other cases, including when we do a
- // developer build (CHANNEL_UNKNOWN).
- if (channel == chrome::VersionInfo::CHANNEL_STABLE ||
- channel == chrome::VersionInfo::CHANNEL_BETA) {
- // TODO(grt) bug=329255: Detect presence of rule on Windows that allows us
- // to do port selection without inducing a dialog.
- // When we have an API to see if the administrative security manager will
- // allow port selection without a security dialog, we may return true if
- // we're sure there will be no security dialog.
- return false;
- }
- return true;
-#else
- return true;
-#endif
+ return false; // Default to disabling port selection on all channels.
}
bool IOThread::ShouldEnableQuicPacing(const CommandLine& command_line,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698