Do not generate crash dumps in CrashRecoveryBrowserTest.

Do not generate crash dumps in CrashRecoveryBrowserTest.

BUG=375900
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272220

[hinoka, 2014-05-22 01:06:51]

I'll confess I don't know anything about Chromium-land, but this CL seems sane
to me (Its just a flag that needs to be passed in?).

Paweł: Added you to the review because your named showed up in the blame (in
2009 :P).  This test was flaking out due to writing crash reports into the
/home/chrome-bot/.config/chromium folder.  Can you take a look?

[Paweł Hajdan Jr., 2014-05-22 07:00:26]

LGTM just to avoid blocking you, but I think the comment below is worth
addressing

Feel free to add a TODO for now and send a separate CL for that. Thanks!

https://codereview.chromium.org/294903010/diff/1/chrome/browser/crash_recover...
File chrome/browser/crash_recovery_browsertest.cc (right):

https://codereview.chromium.org/294903010/diff/1/chrome/browser/crash_recover...
chrome/browser/crash_recovery_browsertest.cc:80:
command_line->AppendSwitch(switches::kDisableBreakpad);
Don't we want to disable this for all browser tests? If applicable it'd be good
to at this flag at content layer level.

[Lei Zhang, 2014-05-22 07:21:07]

https://codereview.chromium.org/294903010/diff/1/chrome/browser/crash_recover...
File chrome/browser/crash_recovery_browsertest.cc (right):

https://codereview.chromium.org/294903010/diff/1/chrome/browser/crash_recover...
chrome/browser/crash_recovery_browsertest.cc:80:
command_line->AppendSwitch(switches::kDisableBreakpad);
On 2014/05/22 07:00:27, Paweł Hajdan Jr. wrote:
> Don't we want to disable this for all browser tests? If applicable it'd be
good
> to at this flag at content layer level.

Several years ago, Chromium builds didn't have Breakpad, so this wasn't a
problem.

Now all builds have Breakpad and it's enabled for bots because of
CHROME_HEADLESS. CHROME_HEADLESS also implies no upload, so the files go in the
"Crash Reports" directory. The problem with passing this switch everywhere is
that there's no way to remove the switch. So if a test does need it, we can't
enable Breakpad.

This means when tests (besides this one) crash for any reason, we'd get a few
crash dumps. Thus we have to clean the directory after the test finishes. I
think this is ok, if we just enabled tools/build/scripts/slave/process_dumps.py
for Linux to process and delete the dumps like we do on Windows.

If any case, we certainly don't want the dumps from this test, they are boring
and we don't really want to process them anyway.

[Lei Zhang, 2014-05-22 08:12:18]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-22 08:15:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/294903010/1

[commit-bot: I haz the power, 2014-05-22 17:33:56]

Change committed as 272220