Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7735)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 294903007: Changed host and NPAPI extension permission strings (access -> read and modify), updated unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing typo found in a review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index 9a027a8e86523a110c669210ad11d2237a590cf9..0ea6746ae70c02be2d9f3920ef77abe7043de36f 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -910,8 +910,10 @@ TEST(PermissionsTest, GetWarningMessages_ManyHosts) {
std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
ASSERT_EQ(1u, warnings.size());
- EXPECT_EQ("Access your data on encrypted.google.com and www.google.com",
- base::UTF16ToUTF8(warnings[0]));
+ EXPECT_EQ(
+ "Read and modify your data on encrypted.google.com and "
+ "www.google.com",
+ base::UTF16ToUTF8(warnings[0]));
}
TEST(PermissionsTest, GetWarningMessages_Plugins) {
@@ -927,8 +929,10 @@ TEST(PermissionsTest, GetWarningMessages_Plugins) {
ASSERT_EQ(0u, warnings.size());
#else
ASSERT_EQ(1u, warnings.size());
- EXPECT_EQ("Access all data on your computer and the websites you visit",
- base::UTF16ToUTF8(warnings[0]));
+ EXPECT_EQ(
+ "Read and modify all your data on your computer and the websites "
+ "you visit",
+ base::UTF16ToUTF8(warnings[0]));
#endif
}
@@ -985,7 +989,7 @@ TEST(PermissionsTest, GetWarningMessages_DeclarativeWebRequest) {
std::vector<base::string16> warnings =
provider->GetWarningMessages(set, extension->GetType());
EXPECT_TRUE(Contains(warnings, "Block parts of web pages"));
- EXPECT_FALSE(Contains(warnings, "Access your data on all websites"));
+ EXPECT_FALSE(Contains(warnings, "Read and modify your data on all websites"));
// Now verify that declarativeWebRequest does not produce a message when host
// permissions do cover all hosts.
@@ -994,7 +998,7 @@ TEST(PermissionsTest, GetWarningMessages_DeclarativeWebRequest) {
set = extension->GetActivePermissions().get();
warnings = provider->GetWarningMessages(set, extension->GetType());
EXPECT_FALSE(Contains(warnings, "Block parts of web pages"));
- EXPECT_TRUE(Contains(warnings, "Access your data on all websites"));
+ EXPECT_TRUE(Contains(warnings, "Read and modify your data on all websites"));
}
TEST(PermissionsTest, GetWarningMessages_Serial) {

Powered by Google App Engine
This is Rietveld 408576698