Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 294903007: Changed host and NPAPI extension permission strings (access -> read and modify), updated unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Syntax error fix, specific test now passes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data_unittest.cc
diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc
index aee14a0941c8651f6bb87cfb0ea28321c2ba3ff7..3ca34e970f4ff8347ce557e540a4f376f20d5813 100644
--- a/extensions/common/permissions/permissions_data_unittest.cc
+++ b/extensions/common/permissions/permissions_data_unittest.cc
@@ -243,7 +243,7 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) {
PermissionsData::GetPermissionMessageStrings(extension.get());
// Warning for "tabs" is suppressed by "history" permission.
ASSERT_EQ(5u, warnings.size());
- EXPECT_EQ("Access your data on api.flickr.com",
+ EXPECT_EQ("Read and modify your data on api.flickr.com",
UTF16ToUTF8(warnings[0]));
EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1]));
EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2]));
@@ -261,7 +261,8 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {
PermissionsData::GetPermissionMessageDetailsStrings(extension.get());
ASSERT_EQ(1u, warnings.size());
ASSERT_EQ(1u, warnings_details.size());
- EXPECT_EQ("Access your data on 5 websites", UTF16ToUTF8(warnings[0]));
+ EXPECT_EQ("Read and modify your data on 5 websites",
+ UTF16ToUTF8(warnings[0]));
EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com",
UTF16ToUTF8(warnings_details[0]));
}
@@ -284,8 +285,9 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHosts) {
std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
ASSERT_EQ(1u, warnings.size());
- EXPECT_EQ("Access your data on encrypted.google.com and www.google.com",
- UTF16ToUTF8(warnings[0]));
+ EXPECT_EQ(
+ "Read and modify your data on encrypted.google.com and www.google.com",
+ UTF16ToUTF8(warnings[0]));
}
TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) {
@@ -299,8 +301,10 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) {
ASSERT_EQ(0u, warnings.size());
#else
ASSERT_EQ(1u, warnings.size());
- EXPECT_EQ("Access all data on your computer and the websites you visit",
- UTF16ToUTF8(warnings[0]));
+ EXPECT_EQ(
+ "Read and modify all your data on your computer and the websites you "
+ "visit",
+ UTF16ToUTF8(warnings[0]));
#endif
}
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698