Changed host and NPAPI extension permission strings (access -> read and modify), updated unit tests

Changed host and NPAPI extension permission strings (access -> read and modify), updated unit tests

BUG=364336
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272659

[Chris Thompson, 2014-05-21 19:54:41]

Here's the issue I worked on for you to review.

[radhikabhar, 2014-05-21 20:00:52]

On 2014/05/21 19:54:41, Chris Thompson wrote:
> Here's the issue I worked on for you to review.

LGTM

[felt, 2014-05-21 23:10:03]

On 2014/05/21 20:00:52, radhikabhar wrote:
> On 2014/05/21 19:54:41, Chris Thompson wrote:
> > Here's the issue I worked on for you to review.
> 
> LGTM

chris, can you upload your latest working patchset please?

[felt, 2014-05-21 23:10:16]

On 2014/05/21 23:10:03, felt wrote:
> On 2014/05/21 20:00:52, radhikabhar wrote:
> > On 2014/05/21 19:54:41, Chris Thompson wrote:
> > > Here's the issue I worked on for you to review.
> > 
> > LGTM
> 
> chris, can you upload your latest working patchset please?

and kick off a new trybot run:
git cl try

[Chris Thompson, 2014-05-21 23:13:46]

On 2014/05/21 23:10:16, felt wrote:
> On 2014/05/21 23:10:03, felt wrote:
> > On 2014/05/21 20:00:52, radhikabhar wrote:
> > > On 2014/05/21 19:54:41, Chris Thompson wrote:
> > > > Here's the issue I worked on for you to review.
> > > 
> > > LGTM
> > 
> > chris, can you upload your latest working patchset please?
> 
> and kick off a new trybot run:
> git cl try

Done (didn't realize my patch set was out of date) and done. Looks like trybots
are still failing. Should I be able to see the error logs for them somehow?

[felt, 2014-05-21 23:31:31]

lgtm except for one nit (in the comments)

after you fix that, ask rdevlin.cronin@chromium.org for a review. he's an OWNER
in these directories.

https://codereview.chromium.org/294903007/diff/20001/extensions/extensions_st...
File extensions/extensions_strings.grd (right):

https://codereview.chromium.org/294903007/diff/20001/extensions/extensions_st...
extensions/extensions_strings.grd:202: Read and modify your dat aon <ph
name="WEBSITE_1">$1<ex>www.google.com</ex></ph>
typo: "Read and modify your dat aon"

[Chris Thompson, 2014-05-22 02:45:05]

On 2014/05/21 23:31:31, felt wrote:
> lgtm except for one nit (in the comments)
> 
> after you fix that, ask mailto:rdevlin.cronin@chromium.org for a review. he's
an OWNER
> in these directories.
> 
>
https://codereview.chromium.org/294903007/diff/20001/extensions/extensions_st...
> File extensions/extensions_strings.grd (right):
> 
>
https://codereview.chromium.org/294903007/diff/20001/extensions/extensions_st...
> extensions/extensions_strings.grd:202: Read and modify your dat aon <ph
> name="WEBSITE_1">$1<ex>www.google.com</ex></ph>
> typo: "Read and modify your dat aon"

Fixed in latest patch set.

[Chris Thompson, 2014-05-22 02:52:15]

Adding rdevlin.cronin to reviewers.

Devlin -- as an OWNER on these directories, could you give this a review?
Thanks!

[Devlin, 2014-05-22 15:38:48]

Thanks for the work, Chris!  I think that there's another test that will fail,
ExtensionManagementApiTest.Basics [1] because of the hard-coded string in [2]. 
Can you test that one, and fix it if it fails?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...

https://codereview.chromium.org/294903007/diff/30001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/articles/permission_warnings.html
(right):

https://codereview.chromium.org/294903007/diff/30001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/permission_warnings.html:44:
alt="Permission warning: 'It can: Access your data on api.flickr.com'"
I suspect this alt-text should also change.

https://codereview.chromium.org/294903007/diff/30001/chrome/common/extensions...
chrome/common/extensions/docs/templates/articles/permission_warnings.html:103:
alt="Permission warning: 'It can: Access your data on api.flickr.com and
flickr.com; Read and modify your browsing history'"
And this one.

[Chris Thompson, 2014-05-22 17:03:25]

On 2014/05/22 15:38:48, Devlin wrote:
> Thanks for the work, Chris!  I think that there's another test that will fail,
> ExtensionManagementApiTest.Basics [1] because of the hard-coded string in [2].

> Can you test that one, and fix it if it fails?
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
> [2]
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...
> 

Done. Changed to new string.

>
https://codereview.chromium.org/294903007/diff/30001/chrome/common/extensions...
> File chrome/common/extensions/docs/templates/articles/permission_warnings.html
> (right):
> 
>
https://codereview.chromium.org/294903007/diff/30001/chrome/common/extensions...
> chrome/common/extensions/docs/templates/articles/permission_warnings.html:44:
> alt="Permission warning: 'It can: Access your data on api.flickr.com'"
> I suspect this alt-text should also change.
> 

Done.

>
https://codereview.chromium.org/294903007/diff/30001/chrome/common/extensions...
> chrome/common/extensions/docs/templates/articles/permission_warnings.html:103:
> alt="Permission warning: 'It can: Access your data on http://api.flickr.com
and
> http://flickr.com; Read and modify your browsing history'"
> And this one.

Done.

[Devlin, 2014-05-22 17:12:47]

lgtm

[Chris Thompson, 2014-05-22 17:44:50]

The CQ bit was checked by cthomp@chromium.org

[Chris Thompson, 2014-05-22 17:44:53]

The CQ bit was unchecked by cthomp@chromium.org

[Chris Thompson, 2014-05-22 17:45:36]

The CQ bit was checked by cthomp@chromium.org

[commit-bot: I haz the power, 2014-05-22 17:46:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cthomp@chromium.org/294903007/60001

[Chris Thompson, 2014-05-23 16:43:37]

The CQ bit was checked by cthomp@chromium.org

[commit-bot: I haz the power, 2014-05-23 16:44:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cthomp@chromium.org/294903007/120001

[commit-bot: I haz the power, 2014-05-23 22:36:02]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-24 00:49:09]

Change committed as 272659