Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: chrome/browser/chromeos/login/wizard_controller.h

Issue 294903005: Add browser test for timezone resolve. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove CreateDefaultFakeURLFetcherCreator. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller.h
diff --git a/chrome/browser/chromeos/login/wizard_controller.h b/chrome/browser/chromeos/login/wizard_controller.h
index cdd3c898e99766481a11641b7904e2cf96343c42..cd14bb1c10b31cb1e55d1965b753826fd2898d61 100644
--- a/chrome/browser/chromeos/login/wizard_controller.h
+++ b/chrome/browser/chromeos/login/wizard_controller.h
@@ -286,6 +286,10 @@ class WizardController : public ScreenObserver {
bool server_error,
const base::TimeDelta elapsed);
+ // Returns true if timezone has already been resolved.
+ // Otherwize sets callback and returns false.
Nikita (slow) 2014/05/22 16:30:43 nit: Otherwise
Nikita (slow) 2014/05/22 16:30:43 nit: Maybe revers return order? I.e. returns true
Alexander Alekseev 2014/05/22 19:13:32 Done.
Alexander Alekseev 2014/05/22 19:13:32 Done.
+ bool SetOnTimeZoneResolvedForTesting(const base::Closure& callback);
+
// Whether to skip any screens that may normally be shown after login
// (registration, Terms of Service, user image selection).
static bool skip_post_login_screens_;
@@ -373,11 +377,15 @@ class WizardController : public ScreenObserver {
scoped_ptr<AccessibilityStatusSubscription> accessibility_subscription_;
- base::WeakPtrFactory<WizardController> weak_factory_;
-
scoped_ptr<SimpleGeolocationProvider> geolocation_provider_;
scoped_ptr<TimeZoneProvider> timezone_provider_;
+ // Tests check result of timezone resolve.
+ bool timezone_resolved_;
+ base::Closure on_timezone_resolved_for_testing_;
+
+ base::WeakPtrFactory<WizardController> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(WizardController);
};

Powered by Google App Engine
This is Rietveld 408576698