Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: net/url_request/test_url_fetcher_factory.cc

Issue 294903005: Add browser test for timezone resolve. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove RE2 dependency. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/test_url_fetcher_factory.cc
diff --git a/net/url_request/test_url_fetcher_factory.cc b/net/url_request/test_url_fetcher_factory.cc
index bd4f5e187a36a1d54be6dcb4934acb5a56763f23..ee071d71236b66cc99feb18c6275fc704f880871 100644
--- a/net/url_request/test_url_fetcher_factory.cc
+++ b/net/url_request/test_url_fetcher_factory.cc
@@ -367,7 +367,7 @@ const GURL& FakeURLFetcher::GetURL() const {
FakeURLFetcherFactory::FakeURLFetcherFactory(
URLFetcherFactory* default_factory)
: ScopedURLFetcherFactory(this),
- creator_(base::Bind(&DefaultFakeURLFetcherCreator)),
+ creator_(CreateDefaultFakeURLFetcherCreator()),
default_factory_(default_factory) {
}
@@ -431,6 +431,12 @@ void FakeURLFetcherFactory::ClearFakeResponses() {
fake_responses_.clear();
}
+// static
+FakeURLFetcherFactory::FakeURLFetcherCreator
mmenke 2014/05/21 18:14:10 Definition order should match declaration order.
Alexander Alekseev 2014/05/21 19:02:04 It's after FakeURLFetcherFactory::ClearFakeRespons
mmenke 2014/05/21 19:07:49 Ahh...you're right. Sorry, DefaultFakeURLFetcherC
+FakeURLFetcherFactory::CreateDefaultFakeURLFetcherCreator() {
+ return base::Bind(&DefaultFakeURLFetcherCreator);
+}
+
URLFetcherImplFactory::URLFetcherImplFactory() {}
URLFetcherImplFactory::~URLFetcherImplFactory() {}

Powered by Google App Engine
This is Rietveld 408576698