Issue 294903003: Reland "Fix Heap::IsHeapIterable."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294903003: Reland "Fix Heap::IsHeapIterable." (Closed)

Created:
6 years, 7 months ago by Jarin

Modified:
6 years, 7 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland "Fix Heap::IsHeapIterable." This relands r21388 (+ handlification of an offending function). BUG=373283 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21397

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -79 lines)			Patch
M	src/debug.cc	View		5 chunks	+2 lines, -7 lines	0 comments	Download
M	src/heap.h	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	src/heap.cc	View		3 chunks	+10 lines, -5 lines	0 comments	Download
M	src/heap-profiler.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/liveedit.cc	View	1	7 chunks	+8 lines, -14 lines	0 comments	Download
M	src/runtime.cc	View		7 chunks	+36 lines, -40 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-373283.js	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Jarin

6 years, 7 months ago (2014-05-21 06:44:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r21397 (presubmit successful).