Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 294903002: Blink GC plugin: look for checked namespaces within the list of namespaces. (Closed)

Created:
6 years, 7 months ago by zerny-chromium
Modified:
6 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Blink GC plugin: look for checked namespaces within the list of namespaces. Previously only the innermost namespace was matched against causing structures in, eg, namespace WebCore::Foo to not be checked. BUG=334149 R=haraken@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zerny-chromium
6 years, 7 months ago (2014-05-20 06:55:24 UTC) #1
haraken
LGTM, thanks!
6 years, 7 months ago (2014-05-20 06:56:35 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 7 months ago (2014-05-20 07:29:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/294903002/1
6 years, 7 months ago (2014-05-20 07:29:37 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 07:30:38 UTC) #5
Message was sent while issue was closed.
Change committed as 271608

Powered by Google App Engine
This is Rietveld 408576698